Summary: | [Cairo][Qt] Alpha blending in SVG filters is wrong | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||
Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 525.x (Safari 3.1) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Dirk Schulze
2009-12-11 05:21:33 PST
Created attachment 44679 [details]
correct color spacetransformation SVG Filter for Qt, Cairo
ImageBuffer::platformTransformColorSpace shouldn't transform the alpha channel on sRGB <-> linearRGB on Qt, Cairo.
style-queue ran check-webkit-style on attachment 44679 [details] without any errors.
Comment on attachment 44679 [details]
correct color spacetransformation SVG Filter for Qt, Cairo
Looks sane. Obviously needs updates to those tests too.
(In reply to comment #3) > (From update of attachment 44679 [details]) > Looks sane. Obviously needs updates to those tests too. Looks like both ports don't have pixel tests. The regression tests don't need an update. Comment on attachment 44679 [details] correct color spacetransformation SVG Filter for Qt, Cairo Clearing flags on attachment: 44679 Committed r52049: <http://trac.webkit.org/changeset/52049> All reviewed patches have been landed. Closing bug. |