Bug 32411

Summary: Web Inspector: Do not use ContextMenuItem as value type in custom context menu implementation.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Severity: Normal CC: bweinstein, eric, joepeck, rik, timothy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
[PATCH] Proposed fix.
pfeldman: commit-queue-
[PATCH] Same with a style fix timothy: review+

Description Pavel Feldman 2009-12-11 01:57:21 PST
Rename ContextMenuSelectionHandler to ContextMenuProvider, make it responsible for populating the menu items and owning them.
Comment 1 Pavel Feldman 2009-12-11 04:45:34 PST
Created attachment 44672 [details]
[PATCH] Proposed fix.
Comment 2 Pavel Feldman 2009-12-11 04:48:45 PST
Created attachment 44673 [details]
[PATCH] Same with a style fix
Comment 3 WebKit Review Bot 2009-12-11 04:50:20 PST
Attachment 44673 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/page/ContextMenuProvider.h:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Skipping input 'WebCore/page/ContextMenuSelectionHandler.h': Can't open for reading
Total errors found: 1
Comment 4 Eric Seidel (no email) 2009-12-28 23:37:04 PST
Comment 5 Pavel Feldman 2009-12-29 01:27:06 PST
Landed manually long ago. Sorry for not updating the bug.