Summary: | Web Inspector: Do not use ContextMenuItem as value type in custom context menu implementation. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bweinstein, eric, joepeck, rik, timothy, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pavel Feldman
2009-12-11 01:57:21 PST
Created attachment 44672 [details]
[PATCH] Proposed fix.
Created attachment 44673 [details]
[PATCH] Same with a style fix
Attachment 44673 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/page/ContextMenuProvider.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4]
Skipping input 'WebCore/page/ContextMenuSelectionHandler.h': Can't open for reading
Total errors found: 1
Ping? Landed manually long ago. Sorry for not updating the bug. |