Bug 32396

Summary: Move run_command onto Executive to make code which uses run_command testable
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2009-12-10 15:18:05 PST
Move run_command onto Executive to make code which uses run_command testable I also moved the error handlers.
Attachments
Patch (7.48 KB, patch)
2009-12-10 15:20 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-12-10 15:20:41 PST
Created attachment 44641 [details] Patch
WebKit Review Bot
Comment 2 2009-12-10 15:24:32 PST
style-queue ran check-webkit-style on attachment 44641 [details] without any errors.
Adam Barth
Comment 3 2009-12-10 15:26:53 PST
Comment on attachment 44641 [details] Patch Ok. Obviously we want return Executive().run_command(*args, **kwargs) to die at some point. :)
Eric Seidel (no email)
Comment 4 2009-12-10 15:28:03 PST
Yes, of course. This just makes it possible for new code to "do the right thing". I just finished breaking out the bugzilla credential logic into its own class, but needed this refactor in order to test it well.
WebKit Commit Bot
Comment 5 2009-12-10 15:47:43 PST
Comment on attachment 44641 [details] Patch Clearing flags on attachment: 44641 Committed r51969: <http://trac.webkit.org/changeset/51969>
WebKit Commit Bot
Comment 6 2009-12-10 15:47:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.