Bug 32379

Summary:

Chromium: Expose devtools agent API for inspector layout tests.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

pfeldman

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed change.	pfeldman: review+, pfeldman: commit-queue-

Ilya Tikhonovsky

Reported 2009-12-10 08:06:59 PST

Test shell's layout tests require access to the inspector controller's methods. We expose them by means of WebDevToolsAgent interfaces as other platforms do it by means of WebInspector interfaces.

Attachments
[PATCH] Proposed change. (1.39 KB, patch) 2009-12-10 08:09 PST, Ilya Tikhonovsky	pfeldman: review+ pfeldman: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2009-12-10 08:09:21 PST

Created attachment 44616 [details] [PATCH] Proposed change. Note that this should be landed once implementation is committed in chromium.

Pavel Feldman

Comment 2 2009-12-10 08:12:49 PST

Comment on attachment 44616 [details] [PATCH] Proposed change. I'll land it once http://codereview.chromium.org/486011 is there.

Pavel Feldman

Comment 3 2009-12-10 08:40:31 PST

Comment on attachment 44616 [details] [PATCH] Proposed change. Just noticed poor naming...

Pavel Feldman

Comment 4 2009-12-10 08:44:32 PST

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/public/WebDevToolsAgent.h Committed r51949

Note You need to log in before you can comment on or make changes to this bug.