Bug 32352

Summary: CommandsTest.assert_execute_outputs doesn't check stderr
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2009-12-09 16:05:24 PST
CommandsTest.assert_execute_outputs doesn't check stderr It tries to, but fails: self.assertEqual(expected_stderr, expected_stderr) Fixing this will undoubtably reveal a bunch of failures.
Attachments
Patch (5.53 KB, patch)
2009-12-11 14:27 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-12-11 14:27:35 PST
Created attachment 44708 [details] Patch
WebKit Review Bot
Comment 2 2009-12-11 14:29:02 PST
style-queue ran check-webkit-style on attachment 44708 [details] without any errors.
Adam Barth
Comment 3 2009-12-11 14:29:30 PST
Comment on attachment 44708 [details] Patch Fantabulous!
WebKit Commit Bot
Comment 4 2009-12-11 14:39:36 PST
Comment on attachment 44708 [details] Patch Clearing flags on attachment: 44708 Committed r52025: <http://trac.webkit.org/changeset/52025>
WebKit Commit Bot
Comment 5 2009-12-11 14:39:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.