Bug 32348

Summary:

Web Inspector: Add context menu actions for DOM tree.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, joepeck, rik, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[IMAGE] Context menu 1	none
[IMAGE] Context menu 2	none
[IMAGE] Context menu 3	none
[PATCH] Proposed change	timothy: review+
[PATCH] Patch with local listener and comment addressed.	timothy: review+

Pavel Feldman

Reported 2009-12-09 14:38:07 PST

Drive-by tiny refactoring of context menu and tree outline cleanup. Items available on tag: Add Attribute ----------- Delete Node Items available on attribute: Add Attribute Edit Attribute ----------- Delete Node Items available on text: Edit Text

Attachments
[IMAGE] Context menu 1 (135.59 KB, image/png) 2009-12-09 14:38 PST, Pavel Feldman	no flags	Details
[IMAGE] Context menu 2 (128.39 KB, image/png) 2009-12-09 14:39 PST, Pavel Feldman	no flags	Details
[IMAGE] Context menu 3 (130.82 KB, image/png) 2009-12-09 14:40 PST, Pavel Feldman	no flags	Details
[PATCH] Proposed change (14.60 KB, patch) 2009-12-09 14:44 PST, Pavel Feldman	timothy: review+	Details Formatted Diff Diff
[PATCH] Patch with local listener and comment addressed. (12.99 KB, patch) 2009-12-09 15:03 PST, Pavel Feldman	timothy: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2009-12-09 14:38:53 PST

Created attachment 44566 [details] [IMAGE] Context menu 1

Pavel Feldman

Comment 2 2009-12-09 14:39:18 PST

Created attachment 44567 [details] [IMAGE] Context menu 2

Pavel Feldman

Comment 3 2009-12-09 14:40:11 PST

Created attachment 44568 [details] [IMAGE] Context menu 3

Pavel Feldman

Comment 4 2009-12-09 14:44:22 PST

Created attachment 44569 [details] [PATCH] Proposed change

Timothy Hatcher

Comment 5 2009-12-09 14:56:37 PST

Comment on attachment 44569 [details] [PATCH] Proposed change > + this.element.addEventListener("contextmenu", this._contextMenuEventFired.bind(this), true); > + > } Extra line.

Pavel Feldman

Comment 6 2009-12-09 15:03:00 PST

Created attachment 44573 [details] [PATCH] Patch with local listener and comment addressed.

Pavel Feldman

Comment 7 2009-12-10 04:54:13 PST

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/front-end/ContextMenu.js M WebCore/inspector/front-end/ElementsTreeOutline.js M WebCore/inspector/front-end/ObjectPropertiesSection.js M WebCore/inspector/front-end/ResourceView.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/StylesSidebarPane.js M WebCore/inspector/front-end/inspector.js M WebCore/inspector/front-end/treeoutline.js Committed r51946

Note You need to log in before you can comment on or make changes to this bug.