| Summary: | exception thrown when running apply-patches | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
Hum... There may be more examples of this. Patch forthcoming. Created attachment 44558 [details]
Patch
Comment on attachment 44558 [details]
Patch
OK. Seems port shoudl just be a global option, no?
Comment on attachment 44558 [details] Patch Clearing flags on attachment: 44558 Committed r51923: <http://trac.webkit.org/changeset/51923> All reviewed patches have been landed. Closing bug. > OK. Seems port shoudl just be a global option, no?
Yes. We need global options to not suck though. :)
|
> bugzilla-tool apply-patches 32313 Cleaning working directory Updating working directory Traceback (most recent call last): File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 104, in <module> BugzillaTool().main() File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/multicommandtool.py", line 253, in main return command.check_arguments_and_execute(args_after_command_name, self) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/multicommandtool.py", line 99, in check_arguments_and_execute return self.execute(command_options, command_args, tool) or 0 File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/commands/download.py", line 86, in execute WebKitApplyingScripts.setup_for_patch_apply(tool, options) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/commands/download.py", line 105, in setup_for_patch_apply update_step.run() File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/buildsteps.py", line 115, in run self._tool.executive.run_and_throw_if_fail(self.port().update_webkit_command()) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/buildsteps.py", line 67, in port self._port = WebKitPort.port(self._options.port) AttributeError: Values instance has no attribute 'port' This is fallout from Adam's recent restructuring.