Bug 32341

Summary:

layout tests timeout when run under valgrind

Product:

WebKit

Reporter:

Doug Muir <dmuir>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric, ggaren, ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
patch that corrects tests that timeout under valgrind	ggaren: review+, commit-queue: commit-queue-
revised patch sans tabs	none

Doug Muir

Reported 2009-12-09 12:48:36 PST

Created attachment 44557 [details] patch that corrects tests that timeout under valgrind A few of the layout tests are timing out when run under valgrind due to timeout callbacks being invoked before specific DOM elements have been parsed/created.

Attachments
patch that corrects tests that timeout under valgrind (2.96 KB, patch) 2009-12-09 12:48 PST, Doug Muir	ggaren: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
revised patch sans tabs (2.95 KB, patch) 2010-01-15 20:46 PST, Geoffrey Garen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Geoffrey Garen

Comment 1 2010-01-15 16:23:08 PST

Comment on attachment 44557 [details] patch that corrects tests that timeout under valgrind r=me

WebKit Commit Bot

Comment 2 2010-01-15 16:57:26 PST

Comment on attachment 44557 [details] patch that corrects tests that timeout under valgrind Rejecting patch 44557 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: Tests/http/tests/misc/timer-vs-loading.html A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following files contain tab characters: trunk/LayoutTests/ChangeLog Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/git/libexec/git-core/git-svn line 558 Full output: http://webkit-commit-queue.appspot.com/results/190616

Geoffrey Garen

Comment 3 2010-01-15 20:46:53 PST

Created attachment 46731 [details] revised patch sans tabs

WebKit Commit Bot

Comment 4 2010-01-15 21:05:56 PST

Comment on attachment 46731 [details] revised patch sans tabs Clearing flags on attachment: 46731 Committed r53356: <http://trac.webkit.org/changeset/53356>

WebKit Commit Bot

Comment 5 2010-01-15 21:06:03 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.