Bug 32328

Summary: Some script binding methods lack INSPECTOR guards
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch 1 for Bug 32328 none

Steve Block
Reported 2009-12-09 10:38:56 PST
ScriptValue::quarantineValue and some overloads of ScriptGlobalObject::set use types which are only defined when INSPECTOR is enabled. These methods should be guarded with ENABLE(INSPECTOR).
Attachments
Patch 1 for Bug 32328 (2.22 KB, patch)
2009-12-09 10:48 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2009-12-09 10:48:21 PST
Created attachment 44545 [details] Patch 1 for Bug 32328
WebKit Review Bot
Comment 2 2009-12-09 10:50:50 PST
style-queue ran check-webkit-style on attachment 44545 [details] without any errors.
WebKit Commit Bot
Comment 3 2009-12-09 14:54:24 PST
Comment on attachment 44545 [details] Patch 1 for Bug 32328 Clearing flags on attachment: 44545 Committed r51927: <http://trac.webkit.org/changeset/51927>
WebKit Commit Bot
Comment 4 2009-12-09 14:54:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.