Summary: | [Chromium] Incorrectly sends WebFrameClient notifications for a detached frame | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Fisher (:fishd, Google) <fishd> | ||||||
Component: | WebKit API | Assignee: | Darin Fisher (:fishd, Google) <fishd> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | beidson, eric, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Darin Fisher (:fishd, Google)
2009-12-09 08:52:17 PST
Created attachment 44541 [details]
v1 patch
style-queue ran check-webkit-style on attachment 44541 [details] without any errors.
Looks sane to me. Comment on attachment 44541 [details]
v1 patch
This is missing a ChangeLog describing what tests this fixes. Otherwise it looks fine though (assuming this is covered by a test). If it's not changing a test, then that's bad, and I would r- this.
oops, not sure why my changelog entry didn't make it into the patch. let me upload again. Created attachment 44559 [details]
v2 patch
With ChangeLog entry this time.
Comment on attachment 44559 [details]
v2 patch
LGTM.
Landed as http://trac.webkit.org/changeset/51917 |