Summary: | ENABLE_ORIENTATION_EVENTS does not compile | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick <phanna> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | android-webkit-unforking, commit-queue, eric | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Comment on attachment 44535 [details] Patch to fix build. > Index: WebCore/ChangeLog ... > + Fix the build with ENABLE_ORIENTATION_EVENTS > + > + * page/Frame.cpp: > + (WebCore::Frame::sendOrientationChangeEvent): the change is good, but please revise the patch to include a bug link in the ChangeLog. Created attachment 44537 [details]
Update changelog with bug url.
Comment on attachment 44537 [details]
Update changelog with bug url.
Rejecting patch 44537 from commit-queue.
Unexpected failure when landing patch! Please file a bug against bugzilla-tool.
Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44537']" exit_code: 1
Last 500 characters of output:
nd_handle_errors
self.run()
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 54, in run
self.clean()
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in clean
step.run()
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/buildsteps.py", line 101, in run
os.chdir(self._tool._scm.checkout_root)
AttributeError: 'NoneType' object has no attribute 'checkout_root'
Oops, cq failed. Can someone landed this patch manually? Comment on attachment 44537 [details]
Update changelog with bug url.
Sorry for the noise. Adam believes to have fixed the issue. I've restarted the commit bot.
Comment on attachment 44537 [details] Update changelog with bug url. Clearing flags on attachment: 44537 Committed r51910: <http://trac.webkit.org/changeset/51910> All reviewed patches have been landed. Closing bug. Please be sure to leave the "Reviewed by NOBODY (OOPS!)." line in your ChangeLogs so that the scripts can correctly mark a reviewer when landing. |
Created attachment 44535 [details] Patch to fix build. Frame.cpp does not compile due to a change in dispatchWindowEvent. Attached is a patch to fix the build.