Bug 32310

Summary:

[bzt] Convert Build to use Sequence

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	eric: review+

Adam Barth

Reported 2009-12-09 01:00:00 PST

LandingSequence is on the way out!

Attachments
Patch (5.68 KB, patch) 2009-12-09 01:01 PST, Adam Barth	no flags	Details Formatted Diff Diff
Patch (9.00 KB, patch) 2009-12-09 01:06 PST, Adam Barth	eric: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2009-12-09 01:01:05 PST

Created attachment 44518 [details] Patch

Eric Seidel (no email)

Comment 2 2009-12-09 01:04:53 PST

Comment on attachment 44518 [details] Patch Should be StepSequence

Adam Barth

Comment 3 2009-12-09 01:06:45 PST

Created attachment 44520 [details] Patch

Eric Seidel (no email)

Comment 4 2009-12-09 01:22:42 PST

Comment on attachment 44520 [details] Patch 45 # FIXME: This class is slowing being killed and replaced with Sequencer. StepSequence The trailing none is unclear: 59 self._sequence.run_and_handle_errors(tool, options, None) 45 collected_options = [option for option in set(collected_options)] call sorted() CheckoutNeedsUpdate does not belong in this thing. :( Needs the above tweaks before landing.

Adam Barth

Comment 5 2009-12-09 01:24:52 PST

Committed r51893: <http://trac.webkit.org/changeset/51893>

Note You need to log in before you can comment on or make changes to this bug.