Bug 32305

Summary:

run_command and ScriptError should move into processutils.py

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	abarth: review+, abarth: commit-queue-

Eric Seidel (no email)

Reported 2009-12-08 23:38:34 PST

run_command and ScriptError should move into processutils.py We need to unify run_command and the other run_ methods. This is a pre-cursor to that unification.

Attachments
Patch (34.59 KB, patch) 2009-12-08 23:42 PST, Eric Seidel (no email)	abarth: review+ abarth: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2009-12-08 23:42:05 PST

Created attachment 44513 [details] Patch

WebKit Review Bot

Comment 2 2009-12-08 23:43:19 PST

style-queue ran check-webkit-style on attachment 44513 [details] without any errors.

Adam Barth

Comment 3 2009-12-08 23:46:36 PST

Comment on attachment 44513 [details] Patch Ok. This is good, but only the first step. We need an executive class, but we'll get to that. Also, there's the indent issue I mentioned.

Eric Seidel (no email)

Comment 4 2009-12-08 23:51:58 PST

Committed r51888: <http://trac.webkit.org/changeset/51888>

Note You need to log in before you can comment on or make changes to this bug.