Summary: | Add "using std::foo" rule checked by script to coding style guidelines | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Jerdonek <cjerdonek> | ||||||
Component: | WebKit Website | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Minor | CC: | cjerdonek, commit-queue, webkit.review.bot | ||||||
Priority: | P4 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
URL: | https://lists.webkit.org/pipermail/webkit-dev/2009-December/010906.html | ||||||||
Attachments: |
|
Description
Chris Jerdonek
2009-12-08 19:40:36 PST
Created attachment 44509 [details]
Proposed patch
Changes made as reported.
Also, all the "using" statement style guidelines now lead with "In header files" or "In implementation files," etc. so it is immediately obvious what types of files each rule applies to.
style-queue ran check-webkit-style on attachment 44509 [details] without any errors.
Comment on attachment 44509 [details] Proposed patch > +<li>In header files in the WTF sub-library, however, it is acceptable > +to use "using" declarations at the end of the file to include one > +or more names in the WTF namespace into the global scope. I think the use of the verb "include" here is strange. I think it should be "add" or "import" instead. Created attachment 44543 [details]
Revised patch
Changed the two uses of "include" to "import" -- as suggested.
style-queue ran check-webkit-style on attachment 44543 [details] without any errors.
Comment on attachment 44543 [details] Revised patch Clearing flags on attachment: 44543 Committed r51929: <http://trac.webkit.org/changeset/51929> All reviewed patches have been landed. Closing bug. |