| Summary: | Cannot open a lot of WebSocket connections | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric, ukai, webkit.review.bot, yuzo | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Mac (Intel) | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
A fix is under review now in the upstream. If you are in a hurry, please make the following change: http://code.google.com/p/pywebsocket/source/diff?format=side&show=review&spec=issue34&r=147&path=/branches/moreconn/src/mod_pywebsocket/standalone.py Yuzo Created attachment 45878 [details]
Update pywebsocket to 0.4.6
style-queue ran check-webkit-style on attachment 45878 [details] without any errors.
Comment on attachment 45878 [details]
Update pywebsocket to 0.4.6
r=me. The patch doesn't include a test case - would be nice to land the attached one at the same time.
Ping? This has been in the pending-commit list for 7 days w/o comment. Just checking in... Committed r53317: <http://trac.webkit.org/changeset/53317> This doesn't quite work on Windows: <http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53421%20(8654)/websocket/tests/multiple-connections-pretty-diff.html>. (In reply to comment #8) > This doesn't quite work on Windows: > <http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53421%20(8654)/websocket/tests/multiple-connections-pretty-diff.html>. This is the cause? 2010-01-18 13:25:39.906 DumpRenderTree_debug.exe[2688:994] *** More than MAXIMUM_WAIT_OBJECTS (64) ports add to a port set. The last ones will be ignored. http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53421%20(8654)/websocket/tests/multiple-connections-stderr.txt Sounds like that! 64 is enough for my purposes - changed the test to only make 50 connections. |
Created attachment 44500 [details] test case (to be run locally) Not sure if it's a SocketStreamHandleCFNet or pywebsocket issue, but I couldn't open more than a few dozen connections to a local WebSocket server. Please see attached test case. I'm getting results as low as 25 or as high as 89 randomly. I want to have at least some large number guaranteed to make a test verifying that WebSocket is not subject to HTTP connection limit (currently 4 or 6 in different implementations, but it would be best to set a much higher threshold in the test).