Summary: | move code generation portions of Nodes.cpp to bytecompiler directory | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Maciej Stachowiak <mjs> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Maciej Stachowiak
2009-12-08 12:58:53 PST
Created attachment 44479 [details]
Patch
Attachment 44479 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/bytecompiler/NodesCodegen.cpp:27: You should add a blank line after implementation file's own header. [build/include_order] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:270: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:538: One line control clauses should not use braces. [whitespace/braces] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:552: One line control clauses should not use braces. [whitespace/braces] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:575: One line control clauses should not use braces. [whitespace/braces] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:598: One line control clauses should not use braces. [whitespace/braces] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:1066: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:1121: One line control clauses should not use braces. [whitespace/braces] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:1269: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:1753: min_num is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:1754: max_num is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 12
I did not fix the style issues identified by the bot, since this was pure code motion, but I will do that in a separate patch. |