Bug 32278

Summary: [Android] Android port lacks Makefiles for building with V8
Product: WebKit Reporter: Steve Block <steveblock>
Component: Tools / TestsAssignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, android-webkit-unforking, commit-queue, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Attachments:
Description Flags
Patch 1 for Bug 32278 none

Steve Block
Reported 2009-12-08 10:35:36 PST
Android port lacks Makefiles for building with V8.
Attachments
Patch 1 for Bug 32278 (55.29 KB, patch)
2009-12-08 15:10 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2009-12-08 15:10:08 PST
Created attachment 44491 [details] Patch 1 for Bug 32278 Adds Makefiles for building on Android with V8 and updates existing Android Makefiles to reflect recent additions to WebKit.
WebKit Review Bot
Comment 2 2009-12-08 15:13:37 PST
style-queue ran check-webkit-style on attachment 44491 [details] without any errors.
Adam Barth
Comment 3 2009-12-09 11:12:55 PST
Comment on attachment 44491 [details] Patch 1 for Bug 32278 This looks reasonable. I'm not actually able to give you a very meaningful review, but the patch seems fine.
WebKit Commit Bot
Comment 4 2009-12-09 14:47:12 PST
Comment on attachment 44491 [details] Patch 1 for Bug 32278 Clearing flags on attachment: 44491 Committed r51926: <http://trac.webkit.org/changeset/51926>
WebKit Commit Bot
Comment 5 2009-12-09 14:47:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.