Bug 32278 - [Android] Android port lacks Makefiles for building with V8
Summary: [Android] Android port lacks Makefiles for building with V8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-08 10:35 PST by Steve Block
Modified: 2009-12-09 14:47 PST (History)
5 users (show)

See Also:


Attachments
Patch 1 for Bug 32278 (55.29 KB, patch)
2009-12-08 15:10 PST, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2009-12-08 10:35:36 PST
Android port lacks Makefiles for building with V8.
Comment 1 Steve Block 2009-12-08 15:10:08 PST
Created attachment 44491 [details]
Patch 1 for Bug 32278

Adds Makefiles for building on Android with V8 and updates existing Android Makefiles to reflect recent additions to WebKit.
Comment 2 WebKit Review Bot 2009-12-08 15:13:37 PST
style-queue ran check-webkit-style on attachment 44491 [details] without any errors.
Comment 3 Adam Barth 2009-12-09 11:12:55 PST
Comment on attachment 44491 [details]
Patch 1 for Bug 32278

This looks reasonable.  I'm not actually able to give you a very meaningful review, but the patch seems fine.
Comment 4 WebKit Commit Bot 2009-12-09 14:47:12 PST
Comment on attachment 44491 [details]
Patch 1 for Bug 32278

Clearing flags on attachment: 44491

Committed r51926: <http://trac.webkit.org/changeset/51926>
Comment 5 WebKit Commit Bot 2009-12-09 14:47:17 PST
All reviewed patches have been landed.  Closing bug.