Bug 32274

Summary: Fails to build on FreeBSD, IA64, and Alpha.
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed fix
darin: review-, gustavo: commit-queue-
proposed fix - second try darin: review+, gustavo: commit-queue-

Gustavo Noronha (kov)
Reported 2009-12-08 07:31:55 PST
Summary says it all, these platforms fail to build WebKit.
Attachments
proposed fix (1.81 KB, patch)
2009-12-08 07:32 PST, Gustavo Noronha (kov) 		darin: review-
gustavo: commit-queue-
DetailsFormatted DiffDiff
proposed fix - second try (1.81 KB, patch)
2009-12-08 09:35 PST, Gustavo Noronha (kov) 		darin: review+
gustavo: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2009-12-08 07:32:33 PST
Created attachment 44470 [details] proposed fix
WebKit Review Bot
Comment 2 2009-12-08 07:37:33 PST
style-queue ran check-webkit-style on attachment 44470 [details] without any errors.
Darin Adler
Comment 3 2009-12-08 07:45:23 PST
Comment on attachment 44470 [details] proposed fix > -#if PLATFORM(X86_64) && (PLATFORM(DARWIN) || PLATFORM(LINUX) || PLATFORM(WIN_OS)) > +#if (PLATFORM(X86_64) && PLATFORM(UNIX)) || PLATFORM(IA64) || PLATFORM(ALPHA) || PLATFORM(WIN_OS) > #define WTF_USE_JSVALUE64 1 This will incorrectly define WTF_USE_JSVALUE64 on 32-bit WIN_OS builds.
Gustavo Noronha (kov)
Comment 4 2009-12-08 09:35:42 PST
Created attachment 44475 [details] proposed fix - second try Good catch! Second try.
Gustavo Noronha (kov)
Comment 5 2009-12-08 14:45:03 PST
Landed as 51871.
Note You need to log in before you can comment on or make changes to this bug.