Bug 32266

Summary: WebSocket must allow space (U+0020) in sub protocol name
Product: WebKit Reporter: Fumitoshi Ukai <ukai>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
WebSocket allow space (U+0020) in sub protocol name. darin: review+

Fumitoshi Ukai
Reported 2009-12-08 00:34:41 PST
Latest WebSocket API / protocol spec draft allow space (U+0020) in sub protocol name.
Attachments
WebSocket allow space (U+0020) in sub protocol name. (7.40 KB, patch)
2009-12-08 00:48 PST, Fumitoshi Ukai 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fumitoshi Ukai
Comment 1 2009-12-08 00:48:41 PST
Created attachment 44461 [details] WebSocket allow space (U+0020) in sub protocol name.
Fumitoshi Ukai
Comment 2 2009-12-08 00:50:08 PST
(In reply to comment #1) > Created an attachment (id=44461) [details] > WebSocket allow space (U+0020) in sub protocol name. This patch requires new version of pywebsocket r134 or later.
WebKit Review Bot
Comment 3 2009-12-08 00:50:57 PST
style-queue ran check-webkit-style on attachment 44461 [details] without any errors.
Darin Adler
Comment 4 2009-12-08 07:02:02 PST
Comment on attachment 44461 [details] WebSocket allow space (U+0020) in sub protocol name. > -// Fails if protocol containns an character greater than U+007F. > +// Fails if protocol containns an character greater than U+007E. Typo here "containns".
Fumitoshi Ukai
Comment 5 2009-12-08 19:40:06 PST
Committed r51886: <http://trac.webkit.org/changeset/51886>
Alexey Proskuryakov
Comment 6 2009-12-09 08:34:39 PST
I'm confused - how can the sub-protocol-with-space test work, if corresponding server side fixes aren't made yet (see bug 32249 that has fixes for _validate_protocol)?
Alexey Proskuryakov
Comment 7 2009-12-09 11:21:09 PST
I now read ChangeLog comments, and am no longer confused. Sorry for the noise!
Note You need to log in before you can comment on or make changes to this bug.