Bug 32260 – DOMHTMLInputElement needs getter to match setAutofilled

• Component: DOM
• Status: RESOLVED FIXED

[John Sullivan]

DOMHTMLInputElement includes a setter, setAutofilled, for which there is no corresponding getter. This getter would be convenient in some code I'm working on.

[John Sullivan]

Created attachment 44453 [details]
Patch to add isAutofilled to Mac and Windows WebKit

[John Sullivan]

Comment on attachment 44453 [details]
Patch to add isAutofilled to Mac and Windows WebKit

D'oh! That was the wrong patch. Please ignore.

[John Sullivan]

Created attachment 44454 [details]
Patch to add isAutofilled to Mac and Windows WebKit

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44454 [details] without any errors.

[Ada Chan]

Comment on attachment 44454 [details]
Patch to add isAutofilled to Mac and Windows WebKit


> +HRESULT STDMETHODCALLTYPE DOMHTMLInputElement::isAutofilled(
> +    /* [retval][out] */ BOOL* result)
> +{
> +    ASSERT(m_element && m_element->hasTagName(inputTag));

Maybe separate the ASSERT into two lines?


> +    HTMLInputElement* inputElement = static_cast<HTMLInputElement*>(m_element);
> +    *result = inputElement->isAutofilled() ? TRUE : FALSE;
> +    return S_OK;
> +}
> +

r=me

[John Sullivan]

Fixed in r51850.

[John Sullivan]

Oops, I forgot to split apart the assertion as suggested in the review. I'll do that as a separate patch.