Bug 32254

Summary: Implement property enumerator for V8NPObject
Product: WebKit Reporter: Victor Wang <victorw>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ager, commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed Patch
none
Proposed Patch + Style fixes none

Description Victor Wang 2009-12-07 15:30:26 PST 
Need to implement NamedPropertyEnumerator and IndexedPropertyEnumerator for V8NPObject so it can be enumerated. This is one reason why the following layout test fails in Chromium:
LayoutTests/plugins/netscape-enumerate.html
Comment 1 Victor Wang 2009-12-07 15:42:41 PST 
Created attachment 44439 [details]
Proposed Patch
Comment 2 WebKit Review Bot 2009-12-07 15:46:02 PST 
style-queue ran check-webkit-style on attachment 44439 [details] without any errors.
Comment 3 Victor Wang 2009-12-07 16:16:33 PST 
Created attachment 44441 [details]
Proposed Patch + Style fixes

Some existing code do not meet the Webkit style guidelines, the new patch fixes them.
Comment 4 WebKit Review Bot 2009-12-07 16:16:58 PST 
style-queue ran check-webkit-style on attachment 44441 [details] without any errors.
Comment 5 Dimitri Glazkov (Google) 2009-12-07 20:18:34 PST 
Comment on attachment 44441 [details]
Proposed Patch + Style fixes

Looks great, thanks for working on this.
Comment 6 WebKit Commit Bot 2009-12-07 20:33:43 PST 
Comment on attachment 44441 [details]
Proposed Patch + Style fixes

Clearing flags on attachment: 44441

Committed r51831: <http://trac.webkit.org/changeset/51831>
Comment 7 WebKit Commit Bot 2009-12-07 20:33:49 PST 
All reviewed patches have been landed.  Closing bug.