Bug 32253
| Summary: | Consider changing WebSocket test server root to match Apache | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Enhancement | CC: | bfulgham, ukai, wilander, yuzo |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Alexey Proskuryakov
For WebKit HTTP tests, the root is LayoutTests/http/tests, but for WebSocket ones, it's LayoutTests/. Is there a reason for such a difference? It's somewhat confusing, and makes one use longer paths in tests.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yuzo Fujishima
The root has been chosen such that LayoutTests/fast/js/resources/*.js are
accessible from Web Socket tests.
As an alternative, I considered using a symbolic link from the websocket directory
but decided otherwise, because the SVN's handling of symbolic link on Windows
could confuse developers.
Yuzo
Alexey Proskuryakov
Sharing resources is good, but maybe if would still be better for WebSocket to have its own copy of the files. Since WebSocket tests are all async - unlike most JS tests - this could help us make an easier to use test harness for those. Currently, there is a lot of copy/paste code needed in every test.