Summary: | wx port lacks plugin support on Mac | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kevin Watters <kevinwatters> | ||||||
Component: | WebKit wx | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | kevino, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.6 | ||||||||
Attachments: |
|
Attachment 44425 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/cf/BinaryPropertyList.h:30: Alphabetical sorting problem. [build/include_order] [4]
WebCore/platform/FileSystem.h:48: "CoreFoundation/CFBundle.h" already included at WebCore/platform/FileSystem.h:43 [build/include] [4]
WebCore/plugins/wx/PluginDataWx.cpp:33: Alphabetical sorting problem. [build/include_order] [4]
WebCore/plugins/wx/PluginDataWx.cpp:39: Declaration has space between type name and * in PluginDatabase *db [whitespace/declaration] [3]
WebCore/platform/wx/FileSystemWx.cpp:39: Alphabetical sorting problem. [build/include_order] [4]
WebCore/platform/wx/FileSystemWx.cpp:145: This { should be at the end of the previous line [whitespace/braces] [4]
WebCore/platform/wx/FileSystemWx.cpp:186: Extra space before ) [whitespace/parens] [2]
WebCore/plugins/mac/PluginViewMac.cpp:207: One line control clauses should not use braces. [whitespace/braces] [4]
WebCore/plugins/mac/PluginViewMac.cpp:747: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
WebCore/plugins/mac/PluginViewMac.cpp:749: Extra space after ( in function call [whitespace/parens] [4]
WebCore/plugins/mac/PluginViewMac.cpp:749: Extra space before ) [whitespace/parens] [2]
WebCore/plugins/mac/PluginViewMac.cpp:749: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
WebCore/plugins/mac/PluginViewMac.cpp:750: Extra space after ( in function call [whitespace/parens] [4]
WebCore/plugins/mac/PluginViewMac.cpp:750: Extra space before ) [whitespace/parens] [2]
WebCore/plugins/mac/PluginViewMac.cpp:750: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
WebCore/plugins/mac/PluginViewMac.cpp:752: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
Total errors found: 16
Created attachment 44472 [details]
fixes style issues
Including wx/wx.h first fails the style checker, but is correct based on wx port conventions.
Attachment 44472 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/wx/FileSystemWx.cpp:38: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1
|
Created attachment 44425 [details] add support for plugins on wxMac The Mac wx port needs several small fixes to support plugins.