Summary: | [check-webkit-style] S_OK is a fine identifier | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | Tools / Tests | Assignee: | Shinichiro Hamaji <hamaji> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | levin, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Adam Barth
2009-12-07 09:14:41 PST
Created attachment 44458 [details]
Patch v1
style-queue ran check-webkit-style on attachment 44458 [details] without any errors.
This happened because the style checker considered it is the declaration of S_OK. if (mli && S_OK == mli->EnumCodePages(MIMECONTF_BROWSER, &enumInterface)) { Note that we should warn about the following statement. if (int & S_OK = intValue) { My patch checks the character after the first '='. Comment on attachment 44458 [details] Patch v1 Clearing flags on attachment: 44458 Committed r51835: <http://trac.webkit.org/changeset/51835> All reviewed patches have been landed. Closing bug. |