Bug 32225

Summary: [check-webkit-style] S_OK is a fine identifier
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Shinichiro Hamaji <hamaji>
Status: RESOLVED FIXED    
Severity: Normal CC: levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 none

Description Adam Barth 2009-12-07 09:14:41 PST
WebCore/platform/text/wince/TextCodecWince.cpp:125:  S_OK is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]

https://bugs.webkit.org/show_bug.cgi?id=32169#c2

That's a false positive.
Comment 1 Shinichiro Hamaji 2009-12-07 21:15:39 PST
Created attachment 44458 [details]
Patch v1
Comment 2 WebKit Review Bot 2009-12-07 21:18:03 PST
style-queue ran check-webkit-style on attachment 44458 [details] without any errors.
Comment 3 Shinichiro Hamaji 2009-12-07 21:20:06 PST
This happened because the style checker considered it is the
declaration of S_OK.

if (mli && S_OK == mli->EnumCodePages(MIMECONTF_BROWSER, &enumInterface)) {

Note that we should warn about the following statement.

if (int & S_OK = intValue) {

My patch checks the character after the first '='.
Comment 4 Shinichiro Hamaji 2009-12-07 21:58:51 PST
Comment on attachment 44458 [details]
Patch v1

Clearing flags on attachment: 44458

Committed r51835: <http://trac.webkit.org/changeset/51835>
Comment 5 Shinichiro Hamaji 2009-12-07 21:59:00 PST
All reviewed patches have been landed.  Closing bug.