Summary: | Turn on (SVG) Filters support, by default. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, krit, mjs, rwlbuis, staikos, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 68469, 26389 | ||||||||
Attachments: |
|
Description
Nikolas Zimmermann
2009-12-07 08:59:31 PST
Created attachment 44418 [details]
Patch, excluding LayoutTests changes
Follow-up patch, will contain the LayoutTest results (big list of changes, all filter affected tests have to be rebaselined).
style-queue ran check-webkit-style on attachment 44418 [details] without any errors.
Comment on attachment 44418 [details] Patch, excluding LayoutTests changes > + Turn on (SVG) Filters support, by default. > + https://bugs.webkit.org/show_bug.cgi?id=32224 rs=me from the impressions I got from the webkit-dev thread. According to Niko we do have enough auto tests for SVG filters. Landed patch enabling mac build in r51800. Waiting for bot results before proceeding. Comment on attachment 44418 [details]
Patch, excluding LayoutTests changes
Clearing review flag, this patch has been landed.
All mac build slaves work fine, w/o regression since turning on filters. Qt has filters turned out, w/o layout test failures since r51841. Now gtk... (In reply to comment #6) > All mac build slaves work fine, w/o regression since turning on filters. > Qt has filters turned out, w/o layout test failures since r51841. > Now gtk... s/turned out/turned on/ Gtk + Filters work properly after r51847 (bots green). Created attachment 44473 [details]
Build patches for win
Adding the win patches, so I can show them around before landing. Already got a blind rs=mjs, given that I'm willing to watch builds and fix :-)
(In reply to comment #9) > Created an attachment (id=44473) [details] > Build patches for win > > Adding the win patches, so I can show them around before landing. Already got a > blind rs=mjs, given that I'm willing to watch builds and fix :-) Filter are activated on every port. Can we close this bug now? Agreed. Closing. |