Bug 32192

Summary:

[check-webkit-style] False positive for camel case of JSC op codes

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, levin, mjs, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	abarth: review+

Description Adam Barth 2009-12-06 08:44:02 PST

According to <https://bugs.webkit.org/show_bug.cgi?id=32190#c7>, check-webkit-style should have an exception for the camelCase naming rule for JavaScript OP codes.  Mjs suggests that we white list variables with the substring "_op_", possibly only in the JavaScriptCore directory.

Comment 1 David Levin 2009-12-07 18:07:53 PST

Created attachment 44456 [details]
Patch

Comment 2 David Levin 2009-12-07 18:09:18 PST

Created attachment 44457 [details]
Patch

Comment 3 WebKit Review Bot 2009-12-07 18:11:37 PST

style-queue ran check-webkit-style on attachment 44457 [details] without any errors.

Comment 4 Adam Barth 2009-12-08 10:18:55 PST

Comment on attachment 44457 [details]
Patch

Thanks!

Comment 5 David Levin 2009-12-08 10:59:02 PST

Committed as http://trac.webkit.org/changeset/51866