Bug 32181

Summary: Move update-webkit into BuildSteps
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 27162    
Bug Blocks: 32182    
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2009-12-04 19:01:45 PST
We need to move update-webkit out of SCM.py because SCM isn't supposed to know that WebKit exists. The proper place for the knowledge of the existence of update-webkit is in WebKitPort because some ports have specialized update scripts (analogous to build-webkit).
Attachments
Patch (4.98 KB, patch)
2009-12-04 19:02 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (5.27 KB, patch)
2009-12-04 19:02 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-12-04 19:02:19 PST
Created attachment 44343 [details] Patch
Adam Barth
Comment 2 2009-12-04 19:02:54 PST
Created attachment 44344 [details] Patch
WebKit Review Bot
Comment 3 2009-12-04 19:05:28 PST
style-queue ran check-webkit-style on attachment 44344 [details] without any errors.
Eric Seidel (no email)
Comment 4 2009-12-05 00:36:41 PST
Comment on attachment 44344 [details] Patch Wow. Yeah, this is way better! I'll forgive you for lack of test. ;)
Adam Barth
Comment 5 2009-12-05 13:54:47 PST
Comment on attachment 44344 [details] Patch Clearing flags on attachment: 44344 Committed r51729: <http://trac.webkit.org/changeset/51729>
Adam Barth
Comment 6 2009-12-05 13:54:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.