Bug 32181

Summary: Move update-webkit into BuildSteps
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 27162    
Bug Blocks: 32182    
Attachments:
Description Flags
Patch
none
Patch none

Description Adam Barth 2009-12-04 19:01:45 PST 
We need to move update-webkit out of SCM.py because SCM isn't supposed to know that WebKit exists.  The proper place for the knowledge of the existence of update-webkit is in WebKitPort because some ports have specialized update scripts (analogous to build-webkit).
Comment 1 Adam Barth 2009-12-04 19:02:19 PST 
Created attachment 44343 [details]
Patch
Comment 2 Adam Barth 2009-12-04 19:02:54 PST 
Created attachment 44344 [details]
Patch
Comment 3 WebKit Review Bot 2009-12-04 19:05:28 PST 
style-queue ran check-webkit-style on attachment 44344 [details] without any errors.
Comment 4 Eric Seidel (no email) 2009-12-05 00:36:41 PST 
Comment on attachment 44344 [details]
Patch

Wow.  Yeah, this is way better!

I'll forgive you for lack of test. ;)
Comment 5 Adam Barth 2009-12-05 13:54:47 PST 
Comment on attachment 44344 [details]
Patch

Clearing flags on attachment: 44344

Committed r51729: <http://trac.webkit.org/changeset/51729>
Comment 6 Adam Barth 2009-12-05 13:54:53 PST 
All reviewed patches have been landed.  Closing bug.