Bug 32175

Summary: REGRESSION: websocket/tests/url-parsing.html is crashing on Leopard Bot
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.5   
Attachments:
Description Flags
proposed fix eric: review+

Eric Seidel (no email)
Reported 2009-12-04 15:13:22 PST
REGRESSION: websocket/tests/url-parsing.html is crashing on Leopard Bot It just crashed the last 3 builds in a row: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r51714%20(7901)/results.html http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r51715%20(7901)/results.html http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r51716%20(7901)/results.html It does not seem related to the r51714 checkin however.
Attachments
proposed fix (1.77 KB, patch)
2009-12-04 16:43 PST, Alexey Proskuryakov 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2009-12-04 16:12:33 PST
I do sometimes get this assertion on Leopard, but never on SnowLeopard.
Darin Adler
Comment 2 2009-12-04 16:13:11 PST
Makes it sound like a CFNetwork bug.
Alexey Proskuryakov
Comment 3 2009-12-04 16:43:01 PST
Created attachment 44340 [details] proposed fix I think it's just a change in behavior in CFNetwork, not a bug. The fix is a little heavy-handed, as there is no need to call CFWriteStreamClose(), and probably no need to unschedule the read stream. But it seems to work fine in my testing.
Alexey Proskuryakov
Comment 4 2009-12-04 16:44:23 PST
*** Bug 32091 has been marked as a duplicate of this bug. ***
WebKit Review Bot
Comment 5 2009-12-04 16:48:16 PST
style-queue ran check-webkit-style on attachment 44340 [details] without any errors.
Eric Seidel (no email)
Comment 6 2009-12-05 13:05:57 PST
Comment on attachment 44340 [details] proposed fix OK. Here's hoping it stops the crashes. :)
Alexey Proskuryakov
Comment 7 2009-12-05 15:59:38 PST
Committed revision 51732.
Note You need to log in before you can comment on or make changes to this bug.