| Summary: | [Qt] Add setAllowUniversalAccessFromFileURLs to the LayoutTestController | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Rohde Christiansen <kenneth> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
style-queue ran check-webkit-style on attachment 44326 [details] without any errors.
Reviewed by Adam Treat and landed in 51709 Comment on attachment 44326 [details]
Patch
Looks OK. I'm surprised that:
+ m_drt->webPage()->settings()->setAttribute(QWebSettings::LocalContentCanAccessRemoteUrls, enabled);
uses a different way to get to settings than:
m_topLoadingFrame->page()->settings()->setAttribute(QWebSettings::DeveloperExtrasEnabled, true);
Sigh. Please clear the r? when landing. :)
bugzilla-tool land-attachment 44326 [details]
will do that for you in case you need it...
(In reply to comment #3) > (From update of attachment 44326 [details]) > Looks OK. I'm surprised that: > + > m_drt->webPage()->settings()->setAttribute(QWebSettings::LocalContentCanAccessRemoteUrls, > enabled); > > uses a different way to get to settings than: > > m_topLoadingFrame->page()->settings()->setAttribute(QWebSettings::DeveloperExtrasEnabled, > true); It is a bit inconsistent in the file, I will have a look at cleaning it up later. |
Created attachment 44326 [details] Patch Implement the setAllowUniversalAccessFromFileURLs method for the Qt LayoutTestController.