Bug 32162

Summary: Assert in BidiContext is wrong and only works by luck
Product: WebKit Reporter: Adam Treat <manyoso>
Component: TextAssignee: Adam Treat <manyoso>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Fix for assert. mitz: review+

Description Adam Treat 2009-12-04 08:57:26 PST
The first assert in BidiContext only works through sheer luck.  The enum WTF::Unicode::Direction has LeftToRight == 0 and RightToLeft == 1 for both ICU and Qt4.  Other implementations that have different values for this enum will fail.  Fix coming...
Comment 1 Adam Treat 2009-12-04 09:02:48 PST
Created attachment 44319 [details]
Fix for assert.
Comment 2 WebKit Review Bot 2009-12-04 09:07:28 PST
style-queue ran check-webkit-style on attachment 44319 [details] without any errors.
Comment 3 Adam Treat 2009-12-04 09:14:43 PST
Landed with r51697.