Bug 32148

Summary: New History changes do not compile for Chromium/V8
Product: WebKit Reporter: Andrew Wilson <atwilson>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ager, atwilson, dglazkov, fishd, vitalyr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch none

Description Andrew Wilson 2009-12-03 22:16:05 PST 
The new history "pushState" support added in r51644 don't work (compile) under V8/Chromium.

We need to add appropriate V8 bindings and chromium versions of the new History APIs.
Comment 1 Andrew Wilson 2009-12-03 22:30:01 PST 
Created attachment 44295 [details]
proposed patch
Comment 2 Adam Barth 2009-12-03 22:31:26 PST 
Comment on attachment 44295 [details]
proposed patch

ok
Comment 3 Andrew Wilson 2009-12-03 22:42:36 PST 
landed initial patch to allow chromium to compile as r51681.

pushState()/replaceState() are just stubbed out for now in Chromium.
Comment 4 Adam Barth 2009-12-03 23:26:51 PST 
Comment on attachment 44295 [details]
proposed patch

This has landed.
Comment 5 Darin Fisher (:fishd, Google) 2009-12-16 12:17:26 PST 
Closing this bug since we now compile.  I'll open another bug about implementing BackForwardListChromium.cpp and related bits.  (See also: http://code.google.com/p/chromium/issues/detail?id=29393)