Bug 32134

Summary: LayoutTests/transitions/shorthand-transitions.html is flaky
Product: WebKit Reporter: Julie Parent <jparent>
Component: Tools / TestsAssignee: Julie Parent <jparent>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Make tolerances consistent - all now allow for 100ms variation. eric: review+, eric: commit-queue-

Julie Parent
Reported 2009-12-03 14:22:01 PST
This is a timing dependent test, that uses a variety of different tolerances for checking each value - some allow for 100ms variation, others only 50ms. This results in flaky behavior - see http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#maxResults=200&tests=LayoutTests%2Ftransitions%2Fshorthand-transitions.html for the history of this test running on Chromium's bots. For the slowest, most loaded bot, this fails 26% of the time!
Attachments
Make tolerances consistent - all now allow for 100ms variation. (2.08 KB, patch)
2009-12-03 14:37 PST, Julie Parent 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julie Parent
Comment 1 2009-12-03 14:37:42 PST
Created attachment 44268 [details] Make tolerances consistent - all now allow for 100ms variation.
WebKit Review Bot
Comment 2 2009-12-03 14:38:22 PST
style-queue ran check-webkit-style on attachment 44268 [details] without any errors.
Eric Seidel (no email)
Comment 3 2009-12-03 15:20:19 PST
Comment on attachment 44268 [details] Make tolerances consistent - all now allow for 100ms variation. Needs a clearer comment. We discussed in person. Thanks!
Julie Parent
Comment 4 2009-12-03 15:38:53 PST
Comment made better (with math!) and committed in http://trac.webkit.org/changeset/51666.
Note You need to log in before you can comment on or make changes to this bug.