Bug 32134 - LayoutTests/transitions/shorthand-transitions.html is flaky
Summary: LayoutTests/transitions/shorthand-transitions.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Julie Parent
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-03 14:22 PST by Julie Parent
Modified: 2009-12-03 15:38 PST (History)
1 user (show)

See Also:


Attachments
Make tolerances consistent - all now allow for 100ms variation. (2.08 KB, patch)
2009-12-03 14:37 PST, Julie Parent
eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julie Parent 2009-12-03 14:22:01 PST
This is a timing dependent test, that uses a variety of different tolerances for checking each value - some allow for 100ms variation, others only 50ms.

This results in flaky behavior - see http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#maxResults=200&tests=LayoutTests%2Ftransitions%2Fshorthand-transitions.html for the history of this test running on Chromium's bots.  For the slowest, most loaded bot, this fails 26% of the time!
Comment 1 Julie Parent 2009-12-03 14:37:42 PST
Created attachment 44268 [details]
Make tolerances consistent - all now allow for 100ms variation.
Comment 2 WebKit Review Bot 2009-12-03 14:38:22 PST
style-queue ran check-webkit-style on attachment 44268 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-03 15:20:19 PST
Comment on attachment 44268 [details]
Make tolerances consistent - all now allow for 100ms variation.

Needs a clearer comment.  We discussed in person.  Thanks!
Comment 4 Julie Parent 2009-12-03 15:38:53 PST
Comment made better (with math!) and committed in http://trac.webkit.org/changeset/51666.