Bug 32118

Summary: Chromium: Add support for settings containing ":"
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, ossy, timothy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] The fix timothy: review+

Pavel Feldman
Reported 2009-12-03 07:57:00 PST
Current escaping does not handle ":". Aslo has a drive-by fix for setting group id early.
Attachments
[PATCH] The fix (3.10 KB, patch)
2009-12-03 08:04 PST, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-12-03 08:04:17 PST
Created attachment 44242 [details] [PATCH] The fix
WebKit Review Bot
Comment 2 2009-12-03 08:06:08 PST
style-queue ran check-webkit-style on attachment 44242 [details] without any errors.
Pavel Feldman
Comment 3 2009-12-03 08:45:43 PST
Sending WebCore/ChangeLog Sending WebCore/inspector/front-end/WatchExpressionsSidebarPane.js Sending WebKit/chromium/ChangeLog Sending WebKit/chromium/src/InspectorClientImpl.cpp Transmitting file data ....Committed revision 51637.
WebKit Review Bot
Comment 4 2010-06-01 03:32:06 PDT
http://trac.webkit.org/changeset/60469 might have broken Qt Linux ARMv5 Release
Timothy Hatcher
Comment 5 2010-06-01 05:41:42 PDT
This Qt Linux bot shit is getting old.
Eric Seidel (no email)
Comment 6 2010-06-01 22:23:30 PDT
Yup. Since the Qt bots still seem to have network issues, we're going to try bug 39282 as a workaround. We could also just remove them from the set of builders the sherriffbot watches.
Note You need to log in before you can comment on or make changes to this bug.