Bug 32096

Summary: check-webkit-style is too noisy about namespace indenting issues.
Product: WebKit Reporter: David Levin <levin>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
check-webkit-style is too noisy about namespace indenting issues. none

Description David Levin 2009-12-02 17:06:49 PST 
With this fixed, it will only flag the first instance of a namespace indent issue.

This will eliminate the error from appearing when people modify a file (which seems ok) unless they change the first line in a namespace.

It also cuts down on the noise generate by improper indenting so that the output from check-webkit-style is more readable.
Comment 1 David Levin 2009-12-02 17:18:27 PST 
Created attachment 44195 [details]
check-webkit-style is too noisy about namespace indenting issues.
Comment 2 Adam Barth 2009-12-02 21:01:39 PST 
Comment on attachment 44195 [details]
check-webkit-style is too noisy about namespace indenting issues.

Awesome.  Thanks for fixing this.
Comment 3 WebKit Commit Bot 2009-12-02 21:09:07 PST 
Comment on attachment 44195 [details]
check-webkit-style is too noisy about namespace indenting issues.

Clearing flags on attachment: 44195

Committed r51619: <http://trac.webkit.org/changeset/51619>
Comment 4 WebKit Commit Bot 2009-12-02 21:09:11 PST 
All reviewed patches have been landed.  Closing bug.