Bug 32094

Summary:

[V8] Attributes and NamedNodeMaps aren't tracked correctly and may be prematurely garbage-collected.

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

WebCore Misc.

Assignee:

Dimitri Glazkov (Google) <dglazkov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ager, fishd, levin, vitalyr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
WIP: Improve V8 bindings attribute story	abarth: review+

Description Dimitri Glazkov (Google) 2009-12-02 15:03:30 PST

I started looking at it after researching the QualifiedName crash (http://crbug.com/27068). Turns out, there's a test for that:

http://trac.webkit.org/changeset/48769

... and Chromium was failing it. So fix is coming up.

Comment 1 Dimitri Glazkov (Google) 2009-12-02 15:12:09 PST

Created attachment 44187 [details]
WIP: Improve V8 bindings attribute story

Comment 2 Dimitri Glazkov (Google) 2009-12-02 15:28:26 PST

Trybots say I am awesome:

http://chrome-tryserver.corp.google.com:8011/builders/layout_linux/builds/829/steps/webkit_tests/logs/stdio

http://build.chromium.org/buildbot/try-server/builders/layout_linux/builds/829

Comment 3 WebKit Review Bot 2009-12-02 21:12:25 PST

style-queue ran check-webkit-style on attachment 44187 [details] without any errors.

Comment 4 Adam Barth 2009-12-02 21:25:05 PST

Comment on attachment 44187 [details]
WIP: Improve V8 bindings attribute story

Ok.  This stuff is pretty subtle, but I'm glad it fixes a LayoutTest!

Comment 5 Dimitri Glazkov (Google) 2009-12-03 08:59:11 PST

Landed as http://trac.webkit.org/changeset/51638.