Bug 32057

Summary:

[bzt] Implement status bubble view

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Adam Barth

Reported 2009-12-02 00:30:49 PST

We need to show a compact representation of the queue statuses to avoid spamming the bug comments.

Attachments
Patch (4.11 KB, patch) 2009-12-02 00:34 PST, Adam Barth	no flags	Details Formatted Diff Diff
Patch (4.21 KB, patch) 2009-12-02 00:55 PST, Adam Barth	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2009-12-02 00:34:13 PST

Created attachment 44132 [details] Patch

WebKit Review Bot

Comment 2 2009-12-02 00:35:58 PST

style-queue ran check-webkit-style on attachment 44132 [details] without any errors.

Eric Seidel (no email)

Comment 3 2009-12-02 00:39:56 PST

Comment on attachment 44132 [details] Patch 79 "Pass": "pass", Doesn't the PEP say it should be: "foo" : "bar"? Please explain this chang ein your ChangeLog: 1 <!DOCTYPE html> Can you provide an example output in the bug for easier review?

Eric Seidel (no email)

Comment 4 2009-12-02 00:45:10 PST

Comment on attachment 44132 [details] Patch Why not do this all at the end? 103 self._summary[attachment_id] = {} make a temporary dictionary up front and assign it at the end. Then less typing. This line is kinda hard to aprse: 6 self._summary[attachment_id][self._queue_name_to_code(queue)] = self._status_to_code(statuses[0].message if statuses else None) We're gonna end up sending a lot of status-bubble html... but we can fix that later. I thought spaces don't matter anymore? <body>{% for key, value in queue_status.items %} 34 <div class="status {{value}}" title="{{key}}: {{value}}">{{key}}</div>{% endfor %} 35 </body>

Adam Barth

Comment 5 2009-12-02 00:50:38 PST

(In reply to comment #3) > (From update of attachment 44132 [details]) > 79 "Pass": "pass", > Doesn't the PEP say it should be: > "foo" : "bar"? I can't find this in the style guide. > Can you provide an example output in the bug for easier review? <!DOCTYPE html> <html> <head> <style> body { font-family: Verdana, sans-serif; margin: 0px; padding: 0px; } .status { display: block; float: left; margin: 1px; padding: 1px 2px; border-radius: 5px; border: 1px solid #AAA; font-size: 11px; } .pass { background-color: #8FDF5F; border: 1px solid #4F8530; } .fail { background-color: #E98080; border: 1px solid #A77272; } .pending { background-color: #FFFC6C; border: 1px solid #C5C56D; } </style> </head> <body> <div class="status fail" title="style: fail">style</div> </body> </html>

Adam Barth

Comment 6 2009-12-02 00:54:25 PST

> I thought spaces don't matter anymore? They're to make the view-source beautiful. :)

Adam Barth

Comment 7 2009-12-02 00:55:50 PST

Created attachment 44134 [details] Patch

WebKit Review Bot

Comment 8 2009-12-02 00:56:29 PST

style-queue ran check-webkit-style on attachment 44134 [details] without any errors.

Eric Seidel (no email)

Comment 9 2009-12-02 00:57:44 PST

Comment on attachment 44134 [details] Patch Looks ok.

WebKit Commit Bot

Comment 10 2009-12-02 01:12:02 PST

Comment on attachment 44134 [details] Patch Clearing flags on attachment: 44134 Committed r51591: <http://trac.webkit.org/changeset/51591>

WebKit Commit Bot

Comment 11 2009-12-02 01:12:07 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.