Bug 32022

Summary: check-webkit-style complains about #imports with / in them
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, benm, hamaji, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+

Description Eric Seidel (no email) 2009-12-01 07:57:44 PST 
check-webkit-style complains about #imports with / in them

https://bugs.webkit.org/show_bug.cgi?id=31915#c4

I expect it has special exclusion rules for #include, but that they're missing for #import in this case.
Comment 1 Adam Barth 2009-12-01 08:18:24 PST 
Investigating.
Comment 2 Adam Barth 2009-12-01 08:27:49 PST 
Created attachment 44081 [details]
Patch
Comment 3 WebKit Review Bot 2009-12-01 08:28:43 PST 
style-queue ran check-webkit-style on attachment 44081 [details] without any errors.
Comment 4 Eric Seidel (no email) 2009-12-01 08:30:40 PST 
Comment on attachment 44081 [details]
Patch

I think I would have written that as:

     if match(r'\s*#\s*(include|import)', line):

Otherwise it looks OK.
Comment 5 Adam Barth 2009-12-01 08:46:59 PST 
Committed r51541: <http://trac.webkit.org/changeset/51541>