Bug 32020

Summary: [Chromium] Provide a way to get ScriptState for the inspected page
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: pfeldman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
abarth: review+
patch addressing comments that I'm going to land none

Yury Semikhatsky
Reported 2009-12-01 07:32:25 PST
InspectorController::didEvaluateForTestInFrontend needs to invoke a function in the inspected page main frame. Would be nice to be able to get ScriptState for the frame.
Attachments
patch (3.15 KB, patch)
2009-12-01 07:34 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
patch (3.16 KB, patch)
2009-12-01 07:36 PST, Yury Semikhatsky 		abarth: review+
DetailsFormatted DiffDiff
patch addressing comments that I'm going to land (3.23 KB, patch)
2009-12-01 08:08 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2009-12-01 07:34:58 PST
Created attachment 44075 [details] patch
WebKit Review Bot
Comment 2 2009-12-01 07:36:45 PST
Attachment 44075 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/v8/ScriptController.cpp:360: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/v8/ScriptController.cpp:362: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/v8/ScriptController.h:51: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3
Yury Semikhatsky
Comment 3 2009-12-01 07:36:55 PST
Created attachment 44076 [details] patch
WebKit Review Bot
Comment 4 2009-12-01 07:42:07 PST
Attachment 44076 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/v8/ScriptController.h:51: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1
Adam Barth
Comment 5 2009-12-01 07:49:58 PST
Comment on attachment 44076 [details] patch Maybe we should call this mainWorldScriptState to be explicit?
Yury Semikhatsky
Comment 6 2009-12-01 08:08:18 PST
Created attachment 44080 [details] patch addressing comments that I'm going to land
Yury Semikhatsky
Comment 7 2009-12-01 08:08:48 PST
(In reply to comment #5) > (From update of attachment 44076 [details]) > Maybe we should call this mainWorldScriptState to be explicit? Done.
Yury Semikhatsky
Comment 8 2009-12-01 08:24:02 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/ScriptController.cpp M WebCore/bindings/v8/ScriptController.h M WebCore/bindings/v8/ScriptState.cpp Committed r51538
Note You need to log in before you can comment on or make changes to this bug.