Summary: | [Chromium] Provide a way to get ScriptState for the inspected page | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Yury Semikhatsky <yurys> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | pfeldman, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Yury Semikhatsky
2009-12-01 07:32:25 PST
Created attachment 44075 [details]
patch
Attachment 44075 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/ScriptController.cpp:360: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
WebCore/bindings/v8/ScriptController.cpp:362: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
WebCore/bindings/v8/ScriptController.h:51: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 3
Created attachment 44076 [details]
patch
Attachment 44076 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/ScriptController.h:51: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1
Comment on attachment 44076 [details]
patch
Maybe we should call this mainWorldScriptState to be explicit?
Created attachment 44080 [details]
patch addressing comments that I'm going to land
(In reply to comment #5) > (From update of attachment 44076 [details]) > Maybe we should call this mainWorldScriptState to be explicit? Done. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/ScriptController.cpp M WebCore/bindings/v8/ScriptController.h M WebCore/bindings/v8/ScriptState.cpp Committed r51538 |