Bug 31976

Summary: Update pywebsocket to 0.4.2.1
Product: WebKit Reporter: Yuzo Fujishima <yuzo>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Update pywebsocket to 0.4.2.1 none

Yuzo Fujishima
Reported 2009-11-29 21:54:18 PST
Update pywebsocket (http://code.google.com/p/pywebsocket/) to 0.4.2.1. 0.4.2 has a bug that some errors are logged to stderr even when log file is specified. For 0.4.2.1 the bug has been fixed.
Attachments
Update pywebsocket to 0.4.2.1 (2.06 KB, patch)
2009-11-29 21:57 PST, Yuzo Fujishima 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yuzo Fujishima
Comment 1 2009-11-29 21:57:13 PST
Created attachment 44007 [details] Update pywebsocket to 0.4.2.1
Adam Barth
Comment 2 2009-11-30 12:49:37 PST
style-queue ran check-webkit-style on attachment 44007 [details] without any errors.
Alexey Proskuryakov
Comment 3 2009-11-30 16:31:04 PST
Comment on attachment 44007 [details] Update pywebsocket to 0.4.2.1 > + Update pywebsocket to 0.4.2.1. Do we really need 4-digit version numbers for pywebsocket? I'm not sure if any version numbers are needed at this point. > + logging.error( > + ('Exception in processing request from: %r' % (client_address,)) + > + '\n' + util.get_stack_trace()) We don't usually wrap such short lines. > + # Note: client_address is a tuple. To match it against %r, we need the > + # trailing comma. Ditto. r=me
WebKit Commit Bot
Comment 4 2009-11-30 16:40:11 PST
Comment on attachment 44007 [details] Update pywebsocket to 0.4.2.1 Clearing flags on attachment: 44007 Committed r51521: <http://trac.webkit.org/changeset/51521>
WebKit Commit Bot
Comment 5 2009-11-30 16:40:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.