|Summary:||[Qt] Remove obsolete PLATFORM(KDE) code|
|Product:||WebKit||Reporter:||Laszlo Gombos <laszlo.gombos>|
|Severity:||Normal||CC:||commit-queue, eric, faure, hausmann, mueller, porten, zack|
|Version:||528+ (Nightly build)|
Description Laszlo Gombos 2009-11-28 22:11:25 PST
KDE is now using the "vanilla" QtWebKit - there is no KDE specific code remained in WebKit. As far as I can this is the case after r18098.
Comment 2 Eric Seidel (no email) 2009-11-29 07:14:31 PST
OK, I believe you. CC'd a few folks who I believe still work on KDE.
Comment 3 Laszlo Gombos 2009-11-29 14:45:41 PST
Thanks Eric for the review. I will wait about a week to see if anyone would object to this and will commit it.
Comment 4 Simon Hausmann 2009-11-29 15:43:45 PST
Nice cleanup! I believe that's the correct change. KDE has now a layer on top of QtWebKit, it does not require a special build/set of #ifdefs.
Comment 5 WebKit Commit Bot 2009-11-30 08:24:06 PST
Comment 6 Eric Seidel (no email) 2009-11-30 08:29:38 PST
The commit queue got stuck on this patch for hours before I restarted it. I think it was a python compilation problem in the end since it went away after restart. bug 31983. It failed very quickly after restart, I've not tried applying it manually, but I believe this is a real compile failure.
Comment 7 Laszlo Gombos 2009-11-30 11:08:15 PST
Comment on attachment 43989 [details] proposed change Clearing review flag as I think the build bot is right this time. Will fix the patch and resubmit for review.
Comment 8 Laszlo Gombos 2009-11-30 11:56:51 PST
Created attachment 44033 [details] Put back Grammar.h to Lexer.cpp is it is guarded with if_n_def KDE_USE_FINAL
Comment 9 WebKit Commit Bot 2009-11-30 12:42:26 PST
Comment on attachment 44033 [details] Put back Grammar.h to Lexer.cpp is it is guarded with if_n_def KDE_USE_FINAL Clearing flags on attachment: 44033 Committed r51505: <http://trac.webkit.org/changeset/51505>
Comment 10 WebKit Commit Bot 2009-11-30 12:42:33 PST
All reviewed patches have been landed. Closing bug.