Summary: | [bzt] style-queue shouldn't reject patches from the commit-queue | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Adam Barth
2009-11-27 16:31:53 PST
Created attachment 43975 [details]
Patch
I don't understand this patch or why it needs a command-line arg. I think the command-line arg is the part that really confuses me (it's kinda ugly). The child process needs to know what to do with errors. The command line argument tells the child what command understands the errors and therefore who should process them. Comment on attachment 43975 [details]
Patch
Seems OK. --parent-command would be better as per our discussion.
Committed r51460: <http://trac.webkit.org/changeset/51460> Patch landed. |