Bug 31943

Summary: Apply workaround for the limitation of VirtualFree with MEM_RELEASE to all ports running on Windows
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, bfulgham, commit-queue, eric, hausmann, sfalken
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch. none

Description Laszlo Gombos 2009-11-27 16:07:20 PST 
This patch is related to commit r47159 (http://trac.webkit.org/changeset/47159). 

On windows we cannot release a part of a region with VirtualFree.  To get around this we'll release the entire region and reallocate the size that we want. 

This needs to be done for all ports running on Windows (Gtk, Qt, Wx, etc) not just for PLATFORM(WIN). PLATFORM(WIN) guard should be changed to PLATFORM(WIN_OS).
Comment 1 Laszlo Gombos 2009-11-27 16:10:06 PST 
Created attachment 43974 [details]
proposed patch.
Comment 2 Eric Seidel (no email) 2009-11-28 09:46:41 PST 
Comment on attachment 43974 [details]
proposed patch.

Looks OK to me.
Comment 3 WebKit Commit Bot 2009-11-28 13:48:26 PST 
Comment on attachment 43974 [details]
proposed patch.

Clearing flags on attachment: 43974

Committed r51461: <http://trac.webkit.org/changeset/51461>
Comment 4 WebKit Commit Bot 2009-11-28 13:48:32 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Hausmann 2009-11-30 00:59:23 PST 
Cherry-picked into QtWebKit 4.6 maintenance branch as 205da189165ea7ba9940bb3bf183b856ce0be874
Comment 6 Adam Roben (:aroben) 2009-11-30 06:45:15 PST 
I wonder if HAVE(VIRTUALALLOC) would be more appropriate?