RESOLVED FIXED31943
Apply workaround for the limitation of VirtualFree with MEM_RELEASE to all ports running on Windows 
https://bugs.webkit.org/show_bug.cgi?id=31943
Summary Apply workaround for the limitation of VirtualFree with MEM_RELEASE to all po...
Laszlo Gombos
Reported 2009-11-27 16:07:20 PST
This patch is related to commit r47159 (http://trac.webkit.org/changeset/47159). On windows we cannot release a part of a region with VirtualFree. To get around this we'll release the entire region and reallocate the size that we want. This needs to be done for all ports running on Windows (Gtk, Qt, Wx, etc) not just for PLATFORM(WIN). PLATFORM(WIN) guard should be changed to PLATFORM(WIN_OS).
Attachments
proposed patch. (1.33 KB, patch)
2009-11-27 16:10 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-11-27 16:10:06 PST
Created attachment 43974 [details] proposed patch.
Eric Seidel (no email)
Comment 2 2009-11-28 09:46:41 PST
Comment on attachment 43974 [details] proposed patch. Looks OK to me.
WebKit Commit Bot
Comment 3 2009-11-28 13:48:26 PST
Comment on attachment 43974 [details] proposed patch. Clearing flags on attachment: 43974 Committed r51461: <http://trac.webkit.org/changeset/51461>
WebKit Commit Bot
Comment 4 2009-11-28 13:48:32 PST
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 5 2009-11-30 00:59:23 PST
Cherry-picked into QtWebKit 4.6 maintenance branch as 205da189165ea7ba9940bb3bf183b856ce0be874
Adam Roben (:aroben)
Comment 6 2009-11-30 06:45:15 PST
I wonder if HAVE(VIRTUALALLOC) would be more appropriate?
Note You need to log in before you can comment on or make changes to this bug.