Bug 31940

Summary:

[XSSAuditor] Make the error messages more descriptive for refused objects and base URL

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, sam

Priority:

Keywords:

XSSAuditor

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch with rebased tests	abarth: review-
Patch with rebased tests	none

Description Daniel Bates 2009-11-27 13:32:23 PST

We should make the error messages more descriptive when we refuse to load an object or refuse to load from the document base URL.

Comment 1 Daniel Bates 2009-11-27 13:35:00 PST

Created attachment 43969 [details]
Patch with rebased tests

Rebased some tests because of the changed console messages.

Comment 2 Adam Barth 2009-11-27 14:09:34 PST

Comment on attachment 43969 [details]
Patch with rebased tests

This is a great idea, but we like to use String::format instead of + to create these kinds of messages.  You can see examples in some of the other console messages.

Comment 3 Daniel Bates 2009-11-27 14:29:15 PST

Created attachment 43970 [details]
Patch with rebased tests

Changed to use String::format. Other examples did not use a static format message, so neither did I.

Comment 4 Adam Barth 2009-11-27 14:37:37 PST

Comment on attachment 43970 [details]
Patch with rebased tests

thanks!

Comment 5 Daniel Bates 2009-11-27 15:05:16 PST

Comment on attachment 43970 [details]
Patch with rebased tests

Clearing flags on attachment: 43970

Committed r51445: <http://trac.webkit.org/changeset/51445>

Comment 6 Daniel Bates 2009-11-27 15:05:22 PST

All reviewed patches have been landed.  Closing bug.