Bug 31935

Summary:

[bzt] unit test ApplyPatches and ApplyAttachment

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	eric: review+

Description Adam Barth 2009-11-27 10:01:37 PST

Turns out I was wrong about WebKitApplyingScripts blocking these tests.  We should kill WebKitApplyingScripts, but it's not as urgent as I though.

Comment 1 Adam Barth 2009-11-27 10:02:40 PST

Created attachment 43958 [details]
Patch

Comment 2 Adam Barth 2009-11-27 10:05:09 PST

Created attachment 43959 [details]
Patch

Comment 3 Eric Seidel (no email) 2009-11-27 10:06:19 PST

Comment on attachment 43959 [details]
Patch

You could make default_options take **kwargs and pass the overrides that way.

Comment 4 Adam Barth 2009-11-27 10:09:45 PST

Committed r51443: <http://trac.webkit.org/changeset/51443>