Bug 31935 - [bzt] unit test ApplyPatches and ApplyAttachment
Summary: [bzt] unit test ApplyPatches and ApplyAttachment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-27 10:01 PST by Adam Barth
Modified: 2009-11-27 10:09 PST (History)
0 users

See Also:

Attachments
Patch (2.41 KB, patch)
2009-11-27 10:02 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (2.38 KB, patch)
2009-11-27 10:05 PST, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-11-27 10:01:37 PST 
Turns out I was wrong about WebKitApplyingScripts blocking these tests.  We should kill WebKitApplyingScripts, but it's not as urgent as I though.
Comment 1 Adam Barth 2009-11-27 10:02:40 PST 
Created attachment 43958 [details]
Patch
Comment 2 Adam Barth 2009-11-27 10:05:09 PST 
Created attachment 43959 [details]
Patch
Comment 3 Eric Seidel (no email) 2009-11-27 10:06:19 PST 
Comment on attachment 43959 [details]
Patch

You could make default_options take **kwargs and pass the overrides that way.
Comment 4 Adam Barth 2009-11-27 10:09:45 PST 
Committed r51443: <http://trac.webkit.org/changeset/51443>