Summary: | REGRESSION(51418): fast/canvas/webgl/gl-object-get-calls.html is failing on the Leopard Commit Bot | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cmarrin, commit-queue, dglazkov, fishd, kbr, oliver | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2009-11-26 11:33:02 PST
bug 21554 was the first failure we've seen like this. All patches have failed on the commit-queue since. I've stopped the queue for now. https://bugs.webkit.org/show_bug.cgi?id=30091 http://trac.webkit.org/changeset/51418 is what started the failures. I'm going to try moving the commit-queue to a different machine as a work-around from my end. I don't have commit rights; can you please comment out the failing line, regenerate the -expected.txt file and commit the result? (In reply to comment #4) > I don't have commit rights; can you please comment out the failing line, > regenerate the -expected.txt file and commit the result? We need to find out why it's failing on some systems but not others, and add logic to ensure identical behaviour. (In reply to comment #5) > (In reply to comment #4) > > I don't have commit rights; can you please comment out the failing line, > > regenerate the -expected.txt file and commit the result? > > We need to find out why it's failing on some systems but not others, and add > logic to ensure identical behaviour. We need to get the commit queue reopened. There is already a bug about the unportability of this test: https://bugs.webkit.org/show_bug.cgi?id=31843 . (In reply to comment #4) > I don't have commit rights; can you please comment out the failing line, > regenerate the -expected.txt file and commit the result? That sounds like it would have the effect of breaking the test on the build bots. That makes it an unacceptable solution. Created attachment 43939 [details] Patch Temporarily disabled portion of test which is failing on some machines but not others. Root cause will be investigated under https://bugs.webkit.org/show_bug.cgi?id=31843 . This is the correct fix for this issue. The remaining portions of the test are both valid and valuable. Comment on attachment 43939 [details] Patch Looks fine to me. Thank you for the quick fix. As noted in comment #3, I attempted to move the commit-bot to a new machine. That move was successful. (As you can see at http://webkit-commit-queue.appspot.com/), but this fix will make the tests pass correctly for everyone (including the old commit-bot machine if we need to move it back). Setting cq+ too since I don't see you in committers.py yet. Should be landed within 15 minutes or so while we return to enjoying our post-turkey haze. :) Comment on attachment 43939 [details] Patch Clearing flags on attachment: 43939 Committed r51441: <http://trac.webkit.org/changeset/51441> All reviewed patches have been landed. Closing bug. |