| Summary: | SVG feImage support | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||||
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, jeffschiller, webkit.review.bot, zimmermann | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 525.x (Safari 3.1) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 68469, 12027, 26389 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dirk Schulze
2009-11-26 01:21:46 PST
Created attachment 43919 [details] SVG feImage support This is the implementation if feImage. It still lacks RenderObject* support, to draw parts of the SVG as image. See bug 12027. Attachment 43919 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/svg/SVGImageLoader.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
Done processing WebCore/svg/SVGImageLoader.cpp
Done processing WebCore/rendering/RenderSVGImage.cpp
Done processing WebCore/svg/SVGFEImageElement.h
Done processing WebCore/svg/SVGPreserveAspectRatio.h
WebCore/svg/SVGPreserveAspectRatio.cpp:176: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
WebCore/svg/SVGPreserveAspectRatio.cpp:191: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
WebCore/svg/SVGPreserveAspectRatio.cpp:210: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
WebCore/svg/SVGPreserveAspectRatio.cpp:227: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
Done processing WebCore/svg/SVGPreserveAspectRatio.cpp
Done processing WebCore/svg/SVGFEImageElement.cpp
Done processing WebCore/svg/graphics/filters/SVGFEImage.h
Done processing WebCore/rendering/RenderSVGImage.h
WebCore/svg/SVGImageLoader.h:30: Code inside a namespace should not be indented. [whitespace/indent] [4]
Done processing WebCore/svg/SVGImageLoader.h
Done processing WebCore/svg/graphics/filters/SVGFEImage.cpp
Total errors found: 6
Created attachment 44105 [details]
SVG feImage support
fixed style issues.
style-queue ran check-webkit-style on attachment 44105 [details] without any errors.
Comment on attachment 44105 [details]
SVG feImage support
The current patch does not account notifyFinished. I'll upload a new patch.
Created attachment 45964 [details]
SVG feImage support
SVG feImage support.
Attachment 45964 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Traceback (most recent call last):
File "WebKitTools/Scripts/check-webkit-style", line 98, in <module>
main()
File "WebKitTools/Scripts/check-webkit-style", line 62, in main
defaults = style.ArgumentDefaults(style.DEFAULT_OUTPUT_FORMAT,
AttributeError: 'module' object has no attribute 'ArgumentDefaults'
Comment on attachment 45964 [details]
SVG feImage support
Can't remember how many times we reiterated this patch.... it's soo perfect this time :-) Enthusiastically r+ed!
|